GHSA-FF5X-W9WG-H275高危已审查

Holder can generate proof of ownership for credentials it does not control in vp-toolkit

OSV 1.4.0 · github-reviewed · 修改于 2020-02-29 00:38

发布时间

2020-03-06 09:15

GitHub 审查时间

2020-02-29 00:38

NVD 发布时间

—

源文件

advisories/github-reviewed/2020/03/GHSA-ff5x-w9wg-h275/GHSA-ff5x-w9wg-h275.json

公告说明

Impact

The verifyVerifiablePresentation() method check the cryptographic integrity of the Verifiable Presentation, but it does not check if the credentialSubject.id DID matches the signer of the VP proof.

The verifier is impacted by this vulnerability.

Patches

Patch will be available in version 0.2.2.

Workarounds

Compute the address out of the verifiablePresentation.proof.n.verificationMethod using getAddressFromPubKey() from [email protected] and match it with the credentialSubject.id address from the credential.

References

Github issue

For more information

If you have any questions or comments about this advisory:

Discuss in the existing issue
Contact me

受影响的软件包

标识信息

别名 / CVE

无

CWE

无

软件生态

npm

扩展资料

暂无扩展资料。

CVSS 评分

没有 CVSS 数据。

原始 OSV JSON

{
  "id": "GHSA-ff5x-w9wg-h275",
  "aliases": [],
  "details": "### Impact\nThe [`verifyVerifiablePresentation()`](https://github.com/rabobank-blockchain/vp-toolkit/blob/master/src/service/signers/verifiable-presentation-signer.ts#L97) method check the cryptographic integrity of the Verifiable Presentation, but it does not check if the [`credentialSubject.id`](https://github.com/rabobank-blockchain/vp-toolkit-models/blob/develop/src/model/verifiable-credential.ts#L150) DID matches the signer of the VP proof.\n\nThe **verifier** is impacted by this vulnerability.\n\n### Patches\nPatch will be available in version 0.2.2.\n\n### Workarounds\n- Compute the address out of the `verifiablePresentation.proof.n.verificationMethod` using `getAddressFromPubKey()` from `[email protected]` and match it with the `credentialSubject.id` address from the credential.\n\n### References\n[Github issue](https://github.com/rabobank-blockchain/vp-toolkit/issues/14)\n\n### For more information\nIf you have any questions or comments about this advisory:\n* Discuss in the existing [issue](https://github.com/rabobank-blockchain/vp-toolkit/issues/14)\n* [Contact me](https://github.com/rabomarnix)",
  "summary": "Holder can generate proof of ownership for credentials it does not control in vp-toolkit",
  "affected": [
    {
      "ranges": [
        {
          "type": "ECOSYSTEM",
          "events": [
            {
              "introduced": "0"
            },
            {
              "fixed": "0.2.2"
            }
          ]
        }
      ],
      "package": {
        "name": "vp-toolkit",
        "ecosystem": "npm"
      }
    }
  ],
  "modified": "2020-02-28T16:38:18Z",
  "severity": [],
  "published": "2020-03-06T01:15:46Z",
  "references": [
    {
      "url": "https://github.com/rabobank-blockchain/vp-toolkit/security/advisories/GHSA-ff5x-w9wg-h275",
      "type": "WEB"
    },
    {
      "url": "https://github.com/rabobank-blockchain/vp-toolkit/issues/14",
      "type": "WEB"
    },
    {
      "url": "https://github.com/rabobank-blockchain/vp-toolkit/commit/18a7db84d3265c6ffa10ef63eb37ae1bd4ba192b",
      "type": "WEB"
    }
  ],
  "schema_version": "1.4.0",
  "database_specific": {
    "cwe_ids": [],
    "severity": "HIGH",
    "github_reviewed": true,
    "nvd_published_at": null,
    "github_reviewed_at": "2020-02-28T16:38:18Z"
  }
}