OSV 1.4.0 · github-reviewed · 修改于 2026-09-03 22:56
发布时间
2026-09-03 22:56
GitHub 审查时间
2026-09-03 22:56
NVD 发布时间
—
源文件
advisories/github-reviewed/2026/09/GHSA-gw25-m53r-qh88/GHSA-gw25-m53r-qh88.json
SiYuan's /export/ file handler was hardened against export disclosure (issue #12213) by adding an
IsSubPath(exportBaseDir, fullPath) check and an IsSensitivePath() check in commit bb481e1. These guards
were added only to the main branch of the handler. The handler begins with a short-circuit branch:
if strings.HasPrefix(c.Request.URL.Path, "/export/temp/") {
c.File(filepath.Join(util.TempDir, c.Request.URL.Path))
return
}
This branch joins the broader util.TempDir with the raw, percent-decoded request path and serves it with
neither IsSubPath nor IsSensitivePath. An authenticated request to
/export/temp/%2e%2e/.../etc/passwd traverses out of TempDir and reads arbitrary files - exactly the
sensitive-file disclosure the patch intended to prevent. Present in the latest master.
bb481e1 (the hardening) through the latest master.model.CheckAuth) - but the patch's stated goal is to deny sensitive-file
export even to authorized callers.kernel/server/serve.go serveExport(): the main branch has IsSubPath + IsSensitivePath; the
/export/temp/ short-circuit branch (above it) has neither and uses util.TempDir as its root.
c.Request.URL.Path is percent-decoded by net/http, so %2e%2e becomes .. and filepath.Join collapses it.
bb481e1 / d68bd5a (GHSA-6865-qjcf-286f): guards on
the main branch + IsSensitivePath extended to *.db/*.log./export/export/temp/ short-circuit branch was never covered by the guards (this report).GET /export/<sensitive> (main branch) -> 401/403 (guards work).GET /export/temp/%2e%2e/%2e%2e/.../tmp/<planted-marker> (or /etc/hostname) -> 200 + file content,
demonstrating the unguarded traversal. The PoC reads only a planted marker / /etc/hostname; no credentials.Authenticated arbitrary file read bypassing the sensitive-file protection: /etc/passwd, ~/.ssh/*, SiYuan
*.db workspace data, *.log.
IsSubPath + IsSensitivePath to the /export/temp/ branch (or restrict its root to TempDir/temp with
an IsSubPath check).filepath.Clean the request path and reject ...kernel/server/serve.go serveExport() lines 308-312.