SanitizeFilePath in pkg/utils/utils.go validated that a path stayed under a safe directory by calling strings.HasPrefix(path, safedir). This is a lexical check, not a directory boundary check: /packages-extra/evil starts with
/packages, so it passed. The function did not enforce a path-separator boundary, so any sibling directory whose name began with the safe-directory string was accepted.
Callers included the builder's Clean handler (pkg/builder/builder.go:208) and the fetcher's Fetch / Upload handlers (pkg/fetcher/fetcher.go). A tenant who could pre-create or control a sibling directory under the fetcher /
builder's shared volume could induce a write or read outside the intended safe directory.
Affected
Project: github.com/fission/fission
Versions: all versions through v1.24.0 with SanitizeFilePath in the tree
PR #3445 (commit 8298e33e) — migrate every SanitizeFilePath call site (fetcher: storePath /
tmpPath / secretDir / configDir / rename + writeSecretOrConfigMap; builder: srcPkg / deployPkg path validation and srcPkg stat) to new helpers (, , , ,
) that operate through . enforces directory confinement in the kernel and is recognized by CodeQL as a traversal barrier.
pkg/utils/root.go
RootJoin
RootStat
RootWriteFile
RootMkdirAll
RootRename
os.Root
os.Root
go/path-injection
PR #3446 (commit 5aac6f0b) — delete the deprecated SanitizeFilePath itself once no callers
remained. The vulnerable function no longer exists in the tree.